Ticket #405 (closed defect: fixed)

Opened 3 years ago

Last modified 21 months ago

Lighter2 ignores <noshadows /> and <nolighting /> tags

Reported by: anonymous Owned by: thebolt
Priority: major Milestone:
Component: tools Version: V1.0
Keywords: Cc:

Description

Lighter2 ignores <noshadows /> and <nolighting /> tags and generates unneeded UV-mapping and lightmaps for these objects.

Attachments

world.zip Download (57.2 KB) - added by anonymous 3 years ago.
the unlit world file

Change History

Changed 3 years ago by anonymous

the unlit world file

  Changed 3 years ago by anonymous

Aswell as <invisible />

follow-up: ↓ 5   Changed 3 years ago by res

The underlying problem is that lighter2 sets <nolighting /> on all objects lit by it (to avoid genmesh's software lighting to kick in). Thus from just seeing a <nolighting /> flag lighter2 can't distinguish whether it was given by the user or set by a previous lighter2 run.

  Changed 3 years ago by jorrit

Well I see three possibilities:

1) the object has <nolighting/> set but no lightmap or vertex lighting information. In that case it is an option set by the user and lighter2 should consider it an ojbect it should keep unmodified.

2) the object has <nolighting/> set and it has lightmaps or vertex lighting information. In that case you can assume that the <nolighting/> was added by lighter2 because if it was added by the user you would have fallen in option 1).

3) the object has no <nolighting/> set. In this case the object doesn't have lightmap or vertex lighting information and lighter2 should add it (and the <nolighting/> flag).

So I see no problem here?

Greetings,

  Changed 2 years ago by jorrit

  • owner changed from admin to thebolt
  • status changed from new to assigned

Is this problem still present?

in reply to: ↑ 2   Changed 21 months ago by res

  • status changed from assigned to closed
  • resolution set to fixed

Replying to res:

The underlying problem is that lighter2 sets <nolighting /> on all objects lit by it

In fact, this is wrong. What lighter2 does is set <lighting>no</lighting> on genmeshes - as a mesh object specific setting.

The mesh wrapper flag <nolighting/> is actually respected (r31670 adds improvements in that area, but in principle it was supported before). Thus resolving this bug as fixed.

Add/Change #405 (Lighter2 ignores <noshadows /> and <nolighting /> tags)

Author


E-mail address and user name can be saved in the Preferences.


Action
as closed
 
Note: See TracTickets for help on using tickets.