Warning: Can't synchronize with the repository (Couldn't open Subversion repository /home/crystal/scm/crystal: SubversionException: ("Expected FS format between '1' and '3'; found format '4'", 160043)). Look in the Trac log for more information.

Ticket #810 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

OSXDelegate2D_OpenGL.m accesses non-existent member of NSOpenGLContext

Reported by: eduardop Owned by: sunshine
Priority: major Milestone:
Component: renderer Version: V1.9
Keywords: Cc:

Description (last modified by sunshine) (diff)

In Mac OS X 10.6, the following fails to compile:

- (CGLContextObj) getCGLContext
{
  return _contextAuxiliary;
}

The return line should be replaced with:

return [self CGLContextObj];

Change History

  Changed 4 years ago by sunshine

  • description modified (diff)

  Changed 4 years ago by sunshine

Changing this code unconditionally would break the code for older versions of Mac OS X. Do you happen to know which API version introduced the -CGLContextObj method? If so, we could conditionalize the code to employ that method when present, else fall back to the older hack approach.

  Changed 4 years ago by sunshine

According to the Apple documentation, -CGLContextObj was introduced in 10.3. I don't think we actively support anything before 10.4, so we probably can use this method unconditionally without worrying about the hack approach.

  Changed 4 years ago by sunshine

  • owner changed from thebolt to sunshine
  • status changed from new to accepted

  Changed 4 years ago by sunshine

  • status changed from accepted to closed
  • resolution set to fixed

Fixed in r33867.
Merged into 1.4 with r33868.

Note: See TracTickets for help on using tickets.